Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanups to connector ConnectionKey usage #9333

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Small cleanups to connector ConnectionKey usage #9333

merged 1 commit into from
Sep 29, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 28, 2024

What do these changes do?

  • Add some missing typing
  • Reduce some indent
  • Reduce some dict lookups

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

@bdraco
Small cleanups to connector ConnectionKey usage
ea646ae 
- Add some missing typing
- Reduce some indent
- Reduce some dict lookups
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 28, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (9ab74e2) to head (ea646ae).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9333      +/-   ##
==========================================
- Coverage   98.56%   98.56%   -0.01%     
==========================================
  Files         107      107              
  Lines       34939    34937       -2     
  Branches     4145     4145              
==========================================
- Hits        34438    34436       -2     
  Misses        334      334              
  Partials      167      167
Flag Coverage Δ
CI-GHA 98.44% <100.00%> (-0.01%) ⬇️
OS-Linux 98.11% <100.00%> (-0.01%) ⬇️
OS-Windows 96.52% <100.00%> (-0.01%) ⬇️
OS-macOS 97.80% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.68% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.61% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.67% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.75% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 98.16% <100.00%> (-0.01%) ⬇️
Py-3.13.0-rc.2 98.15% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.57% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.51% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.13% <100.00%> (-0.01%) ⬇️
VM-macos 97.80% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.11% <100.00%> (-0.01%) ⬇️
VM-windows 96.52% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 29, 2024
@bdraco
Copy link
Member Author

bdraco commented Sep 29, 2024

Tested on production ok, but too tired so leaving it for tomorrow to look again after sleep

@bdraco bdraco marked this pull request as ready for review September 29, 2024 00:12
@bdraco
Copy link
Member Author

bdraco commented Sep 29, 2024

Still looks good after sleep

@bdraco bdraco merged commit 2ac962c into master Sep 29, 2024
39 of 42 checks passed
@bdraco bdraco deleted the waiter branch September 29, 2024 13:18
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 29, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/2ac962cc225fa870c7187caf44303e897b38f0fa/pr-9333

Backported as #9338

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 29, 2024
@bdraco @patchback
Small cleanups to connector ConnectionKey usage (#9333)
afa0ff1 
(cherry picked from commit 2ac962c)
@patchback patchback bot mentioned this pull request Sep 29, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 29, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/2ac962cc225fa870c7187caf44303e897b38f0fa/pr-9333

Backported as #9339

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 29, 2024
@bdraco @patchback
Small cleanups to connector ConnectionKey usage (#9333)
f6fecce 
(cherry picked from commit 2ac962c)
@patchback patchback bot mentioned this pull request Sep 29, 2024
Merged
bdraco added a commit that referenced this pull request Sep 29, 2024
@patchback @bdraco
[PR #9333/2ac962cc backport][3.11] Small cleanups to connector Connec…
a62f6a3 
…tionKey usage (#9339)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Sep 29, 2024
@patchback @bdraco
[PR #9333/2ac962cc backport][3.10] Small cleanups to connector Connec…
873fad9 
…tionKey usage (#9338)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco